linux-kernel - Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120206163544.GO3070@opensource.wolfsonmicro.com>
Date:	Mon, 6 Feb 2012 16:35:45 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	cbou@...l.ru, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347
 Battery Charger.

On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> > There's quite a lot of read/modify/write cycles and...

> True but they are basically all in the setup side of things so I'm not
> sure the complexity is justified or appropriate ?

I'm not sure what complexity you mean?  If the interface is too
difficult to use we should fix that but I didn't notice anything in the
driver which should be more than a straight substitution (or deletion of
code in the case of the debugfs file).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)