linux-kernel - Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120206170528.6c74f206@pyramind.ukuu.org.uk>
Date:	Mon, 6 Feb 2012 17:05:28 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	cbou@...l.ru, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347
 Battery Charger.

On Mon, 6 Feb 2012 16:35:45 +0000
Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> > Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:
> 
> > > There's quite a lot of read/modify/write cycles and...
> 
> > True but they are basically all in the setup side of things so I'm not
> > sure the complexity is justified or appropriate ?
> 
> I'm not sure what complexity you mean?  If the interface is too
> difficult to use we should fix that but I didn't notice anything in the
> driver which should be more than a straight substitution (or deletion of
> code in the case of the debugfs file).

The API seems fine to me but you've then got to implement the
writeable/readable/volatile reg callbacks and figure out what is cachable
for the chip and specify it.

Seems like overkill for a chip you poke asynchronously during boot and
then basically let it mind its own business.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/