lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Feb 2012 10:49:39 +0400 From: Anton Vorontsov <anton.vorontsov@...aro.org> To: Oleg Nesterov <oleg@...hat.com> Cc: Greg KH <gregkh@...uxfoundation.org>, KOSAKI Motohiro <kosaki.motohiro@...il.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Paul Mundt <lethal@...ux-sh.org>, Russell King <linux@....linux.org.uk>, Mike Frysinger <vapier@...too.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org Subject: [PATCH 1/8] sysrq: Fix possible race with exiting task sysrq should grab the tasklist lock, otherwise calling force_sig() is not safe, as it might race with exiting task, which ->sighand might be set to NULL already. Signed-off-by: Anton Vorontsov <anton.vorontsov@...aro.org> --- drivers/tty/sysrq.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 7867b7c..a1bcad7 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -322,11 +322,13 @@ static void send_sig_all(int sig) { struct task_struct *p; + read_lock(&tasklist_lock); for_each_process(p) { if (p->mm && !is_global_init(p)) /* Not swapper, init nor kernel thread */ force_sig(sig, p); } + read_unlock(&tasklist_lock); } static void sysrq_handle_term(int key) -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists