linux-kernel - Re: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120207132925.GN3332@opensource.wolfsonmicro.com>
Date:	Tue, 7 Feb 2012 13:29:25 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Liam Girdwood <lrg@...com>, Dmitry Torokhov <dtor@...l.ru>,
	Misael Lopez Cruz <misael.lopez@...com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate
 it from twl core

On Tue, Feb 07, 2012 at 03:01:13PM +0200, Peter Ujfalusi wrote:
> Complete the separation of the twl6040 from the twl core since
> it is a separate chip, not part of the twl6030 PMIC.

Looking good

Reviewed-by: Mark Brown <broonie@...nsource.wolfsonicro.com>

and it looks like you'll save a bunch more code if you're able to
convert over to using a regmap cache.  Note that as a first pass you
just need to define which registers are volatile and enable a cache type
- if defaults are omitted then the values will be read back from the
device to start off with.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)