linux-kernel - Re: [PATCH 3/3][RFC] cpuidle/tracing: Denote the tracepoints as being in rcu_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120207154009.GR5941@linux.vnet.ibm.com>
Date:	Tue, 7 Feb 2012 07:40:09 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rob Herring <robherring2@...il.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Kevin Hilman <khilman@...com>,
	Josh Triplett <josh@...htriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Len Brown <len.brown@...el.com>
Subject: Re: [PATCH 3/3][RFC] cpuidle/tracing: Denote the tracepoints as
 being in rcu_idle_exit() section

On Tue, Feb 07, 2012 at 09:56:56AM -0500, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@...hat.com>
> 
> As the tracepoints in the cpuidle code are called when rcu_idle_exit() is in
> effect, the _rcuidle() version must be used, otherwise the rcu_read_lock()s
> that protect the tracepoint will not be honored.
> 
> Cc: Len Brown <len.brown@...el.com>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Looks good to me!

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  drivers/cpuidle/cpuidle.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 59f4261..6588f43 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -94,13 +94,13 @@ int cpuidle_idle_call(void)
> 
>  	target_state = &drv->states[next_state];
> 
> -	trace_power_start(POWER_CSTATE, next_state, dev->cpu);
> -	trace_cpu_idle(next_state, dev->cpu);
> +	trace_power_start_rcuidle(POWER_CSTATE, next_state, dev->cpu);
> +	trace_cpu_idle_rcuidle(next_state, dev->cpu);
> 
>  	entered_state = target_state->enter(dev, drv, next_state);
> 
> -	trace_power_end(dev->cpu);
> -	trace_cpu_idle(PWR_EVENT_EXIT, dev->cpu);
> +	trace_power_end_rcuidle(dev->cpu);
> +	trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);
> 
>  	if (entered_state >= 0) {
>  		/* Update cpuidle counters */
> -- 
> 1.7.8.3
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/