linux-kernel - Re: [PATCH 4/9] PCI: Fix cardbus bridge resources as optional size handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQUYg8V8RSeh+xiWYxEfSxwEhp9KRXAjVkyhT94Enkqc3Q@mail.gmail.com>
Date:	Tue, 7 Feb 2012 22:11:22 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ram Pai <linuxram@...ibm.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] PCI: Fix cardbus bridge resources as optional size handling

On Tue, Feb 7, 2012 at 9:01 PM, Ram Pai <linuxram@...ibm.com> wrote:
>
> ..snip..
>>        * If we have prefetchable memory support, allocate
>>        * two regions.  Otherwise, allocate one region of
>>        * twice the size.
>>        */
>>       if (ctrl & PCI_CB_BRIDGE_CTL_PREFETCH_MEM0) {
>>               b_res[2].start = pci_cardbus_mem_size;
>>               b_res[2].end = b_res[2].start + pci_cardbus_mem_size - 1;
>>               b_res[2].flags |= IORESOURCE_MEM | IORESOURCE_PREFETCH |
>>                                 IORESOURCE_STARTALIGN;
>>               if (realloc_head) {
>>                       b_res[2].end -= pci_cardbus_mem_size;
>>                       add_to_list(realloc_head, bridge, b_res+2,
>>                                pci_cardbus_mem_size, pci_cardbus_mem_size);
>>               }
>>
>>               /* reduce that to half */
>>               b_res_3_size = pci_cardbus_mem_size;
>>       }
>
> ACK. Ok. got it. This looks correct.

Good, So we have

Acked-by: Ram Pai <linuxram@...ibm.com>
Tested-by: Dominik Brodowski <linux@...inikbrodowski.net>

Hope Jesse will not miss to add them

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/