linux-kernel - Re: [PATCH 1/9] pci: Fix pci cardbus removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120210122019.2ce504f9@jbarnes-desktop>
Date:	Fri, 10 Feb 2012 12:20:19 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ram Pai <linuxram@...ibm.com>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] pci: Fix pci cardbus removal

On Sat,  4 Feb 2012 22:55:00 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> During test busn_res allocation with cardbus, found pci card removal is not
> working anymore, and it turns out it is broken by:
> 
> |commit 79cc9601c3e42b4f0650fe7e69132ebce7ab48f9
> |Date:   Tue Nov 22 21:06:53 2011 -0800
> |
> |    PCI: Only call pci_stop_bus_device() one time for child devices at remove
> 
> that patch changed pci_remove_behind_bridge behavoir that yenta_carbus depends.
> 
> Restore the old behavoir of pci_remove_behind_bridge by:
> 1. rename pci_remove_behind_bridge to __pci_remove_behind_bridge, and let
> 	__pci_remove_bus_device() call it instead.
> 2. add pci-stop_befind_bridge that will stop device under bridge
> 3. add back pci_remove_behind_bridge that will stop and remove device
> 	under bridge.
> 
> This one is for v3.3

Applied to -fixes with Dominik's tested-by.  A nice cleanup on top
might be to rename pci_remove_behind_bridge to
pci_stop_remove_behind_bridge or something to indicate that it's
calling stop each time as well...

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)