linux-kernel - Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F324ECB.7040102@gmail.com>
Date:	Wed, 08 Feb 2012 11:30:35 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Alan Cox <alan@...ux.intel.com>, Sam Ravnborg <sam@...nborg.org>,
	Arnd Bergmann <arnd@...db.de>, Greg KH <gregkh@...e.de>,
	Jiri Slaby <jslaby@...e.cz>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to
 tty/serial/

On 01/06/2012 12:21 AM, Paul Gortmaker wrote:
> --- /dev/null
> +++ b/drivers/tty/serial/8250/Makefile
> @@ -0,0 +1,20 @@
> +#
> +# Makefile for the 8250 serial device drivers.
> +#
> +
> +obj-$(CONFIG_SERIAL_8250)		+= 8250.o
> +obj-$(CONFIG_SERIAL_8250_PNP)		+= 8250_pnp.o
> +obj-$(CONFIG_SERIAL_8250_GSC)		+= 8250_gsc.o
> +obj-$(CONFIG_SERIAL_8250_PCI)		+= 8250_pci.o
> +obj-$(CONFIG_SERIAL_8250_HP300)		+= 8250_hp300.o
> +obj-$(CONFIG_SERIAL_8250_CS)		+= serial_cs.o
> +obj-$(CONFIG_SERIAL_8250_ACORN)		+= 8250_acorn.o
> +obj-$(CONFIG_SERIAL_8250_CONSOLE)	+= 8250_early.o
> +obj-$(CONFIG_SERIAL_8250_FOURPORT)	+= 8250_fourport.o
> +obj-$(CONFIG_SERIAL_8250_ACCENT)	+= 8250_accent.o
> +obj-$(CONFIG_SERIAL_8250_BOCA)		+= 8250_boca.o
> +obj-$(CONFIG_SERIAL_8250_EXAR_ST16C554)	+= 8250_exar_st16c554.o
> +obj-$(CONFIG_SERIAL_8250_HUB6)		+= 8250_hub6.o
> +obj-$(CONFIG_SERIAL_8250_MCA)		+= 8250_mca.o
> +obj-$(CONFIG_SERIAL_8250_FSL)		+= 8250_fsl.o
> +obj-$(CONFIG_SERIAL_8250_DW)		+= 8250_dw.o

...

> diff --git a/drivers/tty/serial/m32r_sio.c b/drivers/tty/serial/8250/m32r_sio.c
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio.c
> rename to drivers/tty/serial/8250/m32r_sio.c
> diff --git a/drivers/tty/serial/m32r_sio.h b/drivers/tty/serial/8250/m32r_sio.h
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio.h
> rename to drivers/tty/serial/8250/m32r_sio.h
> diff --git a/drivers/tty/serial/m32r_sio_reg.h b/drivers/tty/serial/8250/m32r_sio_reg.h
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio_reg.h
> rename to drivers/tty/serial/8250/m32r_sio_reg.h

Hmm, these cannot be built now :(. Why did you move them?

It looks like they should be moved back.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/