| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120208102914.GA32092@1984> Date: Wed, 8 Feb 2012 11:29:14 +0100 From: Pablo Neira Ayuso <pablo@...filter.org> To: Richard Weinberger <richard@....at> Cc: netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, eric.dumazet@...il.com, jengelh@...ozas.de, rostedt@...dmis.org Subject: Re: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support On Sun, Feb 05, 2012 at 01:14:52AM +0100, Richard Weinberger wrote: > This patch introduces NETFILTER_XT_TARGET_LOG_RING. > It allows logging into various ring buffers which are > represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/. > > Signed-off-by: Richard Weinberger <richard@....at> > --- > include/linux/netfilter/xt_LOG.h | 13 +- > include/net/netfilter/nf_log.h | 1 + > include/net/netfilter/xt_log_ring.h | 24 + > net/netfilter/Kconfig | 13 + > net/netfilter/Makefile | 2 + > net/netfilter/xt_LOG.c | 921 ----------------------------- > net/netfilter/xt_LOG_core.c | 1108 +++++++++++++++++++++++++++++++++++ > net/netfilter/xt_LOG_ring.c | 430 ++++++++++++++ Can you avoid this rename and splitting LOG into two files? I prefer having everything into the same file xt_LOG.c. Apart from that, this looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists