linux-kernel - Re: [patch]block: fix ioc locking warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jgudka$pbj$1@dough.gmane.org>
Date:	Wed, 08 Feb 2012 10:07:05 -0800
From:	walt <w41ter@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [patch]block: fix ioc locking warning

On 02/05/2012 11:50 PM, Shaohua Li wrote:

> diff --git a/block/blk-ioc.c b/block/blk-ioc.c
> index 27a06e0..7490b6d 100644
> --- a/block/blk-ioc.c
> +++ b/block/blk-ioc.c
> @@ -204,7 +204,9 @@ void put_io_context(struct io_context *ioc, struct request_queue *locked_q)
>   				spin_unlock(last_q->queue_lock);
>   			last_q = NULL;
>
> -			if (!spin_trylock(this_q->queue_lock))
> +			/* spin_trylock() always successes in UP case */
> +			if (this_q != locked_q&&
> +			    !spin_trylock(this_q->queue_lock))
>   				break;
>   			last_q = this_q;
>   			continue;

I can see from the rest of this thread that your patch fixes a multitude
of different backtraces, including (most importantly :) mine, thanks:

http://marc.info/?l=linux-kernel&m=132804761925018&w=2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/