linux-kernel - RE: [PATCH] kmsg_dump: Don't run on non-error paths by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 8 Feb 2012 15:26:16 -0500
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Matthew Garrett <mjg@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"dzickus@...hat.com" <dzickus@...hat.com>,
	"vgoyal@...hat.com" <vgoyal@...hat.com>
Subject: RE: [PATCH] kmsg_dump: Don't run on non-error paths by default

There was a mistake in writing for my e-mail address.

Acked-by: Seiji Aguchi <seiji.aguchi@....com>


-----Original Message-----
From: Seiji Aguchi 
Sent: Wednesday, February 08, 2012 3:24 PM
To: 'Matthew Garrett'; linux-kernel@...r.kernel.org
Cc: dzickus@...hat.com; vgoyal@...hat.com
Subject: RE: [PATCH] kmsg_dump: Don't run on non-error paths by default

This patch, introducing tunable parameter, is reasonable to me.

Acked-by: Seiji Aguchi <seiji.aguchi.hds.com>

-----Original Message-----
From: Matthew Garrett [mailto:mjg@...hat.com]
Sent: Wednesday, February 08, 2012 11:14 AM
To: linux-kernel@...r.kernel.org
Cc: Seiji Aguchi; dzickus@...hat.com; vgoyal@...hat.com; Matthew Garrett
Subject: [PATCH] kmsg_dump: Don't run on non-error paths by default

Since 04c6862c055fb687c90d9652f32c11a063df15cf kmsg_dump() gets run on normal paths including poweroff and reboot. This is less than ideal given pstore implementations that can only represent single backtraces, since a reboot may overwrite a stored oops before it's been picked up by userspace.
In addition, some pstore backends may have low performance and provide a significant delay in reboot as a result.

This patch adds a printk.always_kmsg_dump kernel parameter (which can also be changed from userspace). Without it, the code will only be run on failure paths rather than on normal paths. The option can be enabled in environments where there's a desire to attempt to audit whether or not a reboot was cleanly requested or not.

Signed-off-by: Matthew Garrett <mjg@...hat.com>
---
 include/linux/kmsg_dump.h |    9 +++++++--
 kernel/printk.c           |    6 ++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/include/linux/kmsg_dump.h b/include/linux/kmsg_dump.h index fee6631..35f7237 100644
--- a/include/linux/kmsg_dump.h
+++ b/include/linux/kmsg_dump.h
@@ -15,13 +15,18 @@
 #include <linux/errno.h>
 #include <linux/list.h>
 
+/*
+ * Keep this list arranged in rough order of priority. Anything listed 
+after
+ * KMSG_DUMP_OOPS will not be logged by default unless 
+printk.always_kmsg_dump
+ * is passed to the kernel.
+ */
 enum kmsg_dump_reason {
-	KMSG_DUMP_OOPS,
 	KMSG_DUMP_PANIC,
+	KMSG_DUMP_OOPS,
+	KMSG_DUMP_EMERG,
 	KMSG_DUMP_RESTART,
 	KMSG_DUMP_HALT,
 	KMSG_DUMP_POWEROFF,
-	KMSG_DUMP_EMERG,
 };
 
 /**
diff --git a/kernel/printk.c b/kernel/printk.c index 13c0a11..e7d07f5 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -702,6 +702,9 @@ static bool printk_time = 0;  #endif  module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
 
+static bool always_kmsg_dump;
+module_param_named(always_kmsg_dump, always_kmsg_dump, bool, S_IRUGO | 
+S_IWUSR);
+
 /* Check if we have any console registered that can be called early in boot. */  static int have_callable_console(void)  { @@ -1732,6 +1735,9 @@ void kmsg_dump(enum kmsg_dump_reason reason)
 	unsigned long l1, l2;
 	unsigned long flags;
 
+	if (reason > KMSG_DUMP_PANIC && !always_kmsg_dump)
+		return;
+
 	/* Theoretically, the log could move on after we do this, but
 	   there's not a lot we can do about that. The new messages
 	   will overwrite the start of what we dump. */
--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/