linux-kernel - Re: [PATCH 1/2] smsc95xx: add module parameter to turn off NIC status leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Feb 2012 15:26:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pmeerw@...erw.net
Cc:	linux-kernel@...r.kernel.org, steve.glendinning@...c.com,
	p.meerwald@...-electronic.com
Subject: Re: [PATCH 1/2] smsc95xx: add module parameter to turn off NIC
 status leds

From: Peter Meerwald <pmeerw@...erw.net>
Date: Wed,  8 Feb 2012 12:08:51 +0100

> From: Peter Meerwald <p.meerwald@...-electronic.com>
> 
> add module parameter to allow to turn off NIC status leds (link, 
> speed, activity); blinking LEDs are annoying outside the server room :)
> 
> default behaviour is not changed, tested on beagleboard-xm
> 
> Signed-off-by: Peter Meerwald <p.meerwald@...-electronic.com>

No.  Create a generic mechanism, perhaps via ethtool, for users to
configure something like this.

Otherwise the next driver that wants to provide this kind of knob
will add yet another module parameter with yet another name, and
this kind of ad-hoc set of interfaces absolutely sucks for users.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/