linux-kernel - Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Feb 2012 12:17:05 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set

On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote:

> +	if (vol || map->cache_type == REGCACHE_NONE) {
> +		ret = _regmap_raw_write(map, reg, val, val_bytes * val_count);

You still need to do the byte swap here.

> +	} else {
> +		for (i = 0; i < val_count; i++) {
> +			memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
> +			ival = map->format.parse_val(map->work_buf);

They're currently symmetric but really this should use format_val().

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)