linux-kernel - Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F33BFDE.7020006@nvidia.com>
Date:	Thu, 9 Feb 2012 18:15:18 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V1] regmap: add bulk_write() for non-volatile register
 set

On Thursday 09 February 2012 05:47 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote:
>
>> +	if (vol || map->cache_type == REGCACHE_NONE) {
>> +		ret = _regmap_raw_write(map, reg, val, val_bytes * val_count);
> You still need to do the byte swap here.
I saw the regmap_raw_write() and it is using the same way without byte 
swapping.
Want to use the same function as it is.. I am not sure why do we require 
byte-swapping in this case. Required things will be done by 
_regmap_raw_write only.
This api just break the transfer in register-wise if any of the register 
is cached..

>> +	} else {
>> +		for (i = 0; i<  val_count; i++) {
>> +			memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
>> +			ival = map->format.parse_val(map->work_buf);
> They're currently symmetric but really this should use format_val().
>
The format_val is require integer argument and issue is that I dont have 
this otherwise I need not to parse, can use directly.

Am I missing something here?


> * Unknown Key
> * 0x6E30FDDD

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/