linux-kernel - RE: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out of the staging area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6E21E5352C11B742B20C142EB499E0481B70CB59@TK5EX14MBXC128.redmond.corp.microsoft.com>
Date:	Thu, 9 Feb 2012 20:51:31 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out
 of the staging area



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@...senPartnership.com]
> Sent: Thursday, February 09, 2012 3:46 PM
> To: KY Srinivasan
> Cc: Greg KH; linux-kernel@...r.kernel.org; devel@...uxdriverproject.org;
> virtualization@...ts.osdl.org; ohering@...e.com; hch@...radead.org; linux-
> scsi@...r.kernel.org
> Subject: RE: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out of the
> staging area
> 
> On Thu, 2012-02-09 at 20:43 +0000, KY Srinivasan wrote:
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > > Sent: Thursday, February 09, 2012 3:24 PM
> > > To: James Bottomley
> > > Cc: KY Srinivasan; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org;
> > > virtualization@...ts.osdl.org; ohering@...e.com; hch@...radead.org; linux-
> > > scsi@...r.kernel.org
> > > Subject: Re: [PATCH 1/1] Staging: hv: storvsc: Move the storage driver out of
> the
> > > staging area
> > >
> > > On Thu, Feb 09, 2012 at 02:18:38PM -0600, James Bottomley wrote:
> > > > On Thu, 2012-02-09 at 12:04 -0800, Greg KH wrote:
> > > > > On Thu, Feb 09, 2012 at 12:04:11PM -0800, K. Y. Srinivasan wrote:
> > > > > > The storage driver (storvsc_drv.c) handles all block storage devices
> > > > > > assigned to Linux guests hosted on Hyper-V. This driver has been in the
> > > > > > staging tree for a while and this patch moves it out of the staging area.
> > > > > > As per Greg's recommendation, this patch makes no changes to the
> > > staging/hv
> > > > > > directory. Once the driver moves out of staging, we will cleanup the
> > > > > > staging/hv directory.
> > > > > >
> > > > > > James was willing to apply this patch during the 3.3-rc phase and a
> decision
> > > > > > was taken to defer this to 3.4 since Greg had queued up a bunch of
> storvsc
> > > > > > patches for 3.4. Now that Greg has applied all of the pending storvsc
> > > patches,
> > > > > > I am re-sending this patch to move this driver out of staging.
> > > > > >
> > > > > >
> > > > > > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > > > > > ---
> > > > > >  drivers/scsi/Kconfig       |    7 +
> > > > > >  drivers/scsi/Makefile      |    3 +
> > > > > >  drivers/scsi/storvsc_drv.c | 1548
> > > ++++++++++++++++++++++++++++++++++++++++++++
> > > > > >  3 files changed, 1558 insertions(+), 0 deletions(-)
> > > > > >  create mode 100644 drivers/scsi/storvsc_drv.c
> > > > >
> > > > > James, any objection to me applying this to the staging-next tree, and
> > > > > at the same time, deleting this version of the driver from the
> > > > > drivers/staging/hv/ directory?
> > > >
> > > > Well, yes, it has the same build failure as the previous one and that
> > > > will make it non bisectable.
> > >
> > > Ah, that would make things a bit difficult, KY, please test your
> > > patches...
> >
> > Greg,
> >
> > I pulled down your staging tree earlier today that had all the storvsc patches
> that you
> > checked in yesterday, applied this patch and built it (successfully).
> 
> You're leaving remnants in staging.
> 
> Move the damn thing and pull the config options from staging when you
> put them in SCSI.

Greg had recommended that the patch moving the driver should not delete the contents
in the staging directory and that he (Greg) would clean up the staging directory. Greg, let me
know if you want me to send you a patch that includes getting rid of the stuff from the staging area.

Regards,

K. Y