linux-kernel - Re: scsi_id: sending ioctl 2285 to a partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Feb 2012 16:00:39 -0500
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
	Doug Nelson <doug.nelson@...el.com>
Subject: Re: scsi_id: sending ioctl 2285 to a partition

On Thu, Feb 09, 2012 at 12:42:00PM -0800, Linus Torvalds wrote:
> On Thu, Feb 9, 2012 at 12:29 PM, Matthew Wilcox <willy@...ux.intel.com> wrote:
> >
> > Commit 0bfc96cb77 adds this printk that triggers tens of thousands of
> > times during a run of "a well-known database benchmark".  0x2285 is SG_IO.
> > I'm not sure why scsi_id feels that it needs to repeatedly send a SCSI
> > INQUIRY to a partition, but there we are.
> 
> So is it doing this as root (in which case we end up allowing it) or
> as a normal user (in which case we end up disallowing it)?

I'm pretty sure it's doing it as root ... it'll be run by udev, after all.

> And does it all work well apart from the printk? Because the printk
> itself is scheduled to be removed, it's only there to hear about users
> that may be doing crazy things that got disallowed by the patches in
> question?

If it is being run as root, then the printk is pointless, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/