linux-kernel - Re: scsi_id: sending ioctl 2285 to a partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwJe=+6M+0AnJ0=1Qy2V3pG=WD+LVbRV1ZC=0PyKNPbpg@mail.gmail.com>
Date:	Thu, 9 Feb 2012 13:11:58 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Matthew Wilcox <willy@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
	Doug Nelson <doug.nelson@...el.com>
Subject: Re: scsi_id: sending ioctl 2285 to a partition

On Thu, Feb 9, 2012 at 1:00 PM, Matthew Wilcox <willy@...ux.intel.com> wrote:
>> And does it all work well apart from the printk? Because the printk
>> itself is scheduled to be removed, it's only there to hear about users
>> that may be doing crazy things that got disallowed by the patches in
>> question?
>
> If it is being run as root, then the printk is pointless, right?

No. The original patch actually disallowed it for everybody, including
root. The "let them through with a warning"

So part of the point of the printk was to see if these things happened
at all. We should have made the root'ness explicit in the printk,
though, to see that part too.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/