linux-kernel - Re: [PATCH] SubmittingPatches: Increase the line length limit from 80 to 100 colums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1202092206040.11004@frira.zrqbmnf.qr>
Date:	Thu, 9 Feb 2012 22:55:45 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Kees Cook <keescook@...omium.org>, Tejun Heo <tj@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] SubmittingPatches: Increase the line length limit from
 80 to 100 colums

On Friday 2012-02-03 11:07, Ingo Molnar wrote:

>[PATCH] SubmittingPatches: Increase the line length limit from 80 to 100 colums
>
>As far as I'm aware I was the last regular kernel contributor who
>still used a standard VGA text console, but both text (100 cols is
>also arguably closer to various brain limits such as vision of field
>and resolution restrictions

Please, no.

(Corollary 1) The older you get, the larger you like your glyphs to
be (...and the FOV is likely to lower as well).

14pt and up usually. And there is not a whole lot that fit on
10.1-inch netbook screens that way.

(Corollary 2) Travelers desire minimizing size and weight.

-----

As for checkpatch, I am throwing in the suggestion to augment checkpatch 
such that it does not look at whether single lines are over $limit, but 
whether a certain percentage of lines of a file is over $limit. That, 
together with a badness value that is e.g. following some power law to 
the amount of chars too much, but not when the line cannot be broken
in the first place. Maybe along the lines of

 #perlish#
 foreach (<>) {
     /^\s+\S+/;
     if (length($_) > length($&)) {
         push @candidate, $_;
         $badness += (length($_) - length($&)) ** 1.5;
     }
 }
 if ($badness > $threshold) {
     warn about @candidate_lines;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/