linux-kernel - Re: [PATCH] SubmittingPatches: Increase the line length limit from 80 to 100 colums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328825357.29329.16.camel@joe2Laptop>
Date:	Thu, 09 Feb 2012 14:09:17 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jan Engelhardt <jengelh@...ozas.de>,
	Andy Whitcroft <apw@...dowen.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Kees Cook <keescook@...omium.org>, Tejun Heo <tj@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] SubmittingPatches: Increase the line length limit from
 80 to 100 colums

On Thu, 2012-02-09 at 22:55 +0100, Jan Engelhardt wrote:
> I am throwing in the suggestion to augment checkpatch 
> such that it does not look at whether single lines are over $limit, but 
> whether a certain percentage of lines of a file is over $limit. That, 
> together with a badness value that is e.g. following some power law to 
> the amount of chars too much, but not when the line cannot be broken
> in the first place. Maybe along the lines of
> 
>  #perlish#
>  foreach (<>) {
>      /^\s+\S+/;
>      if (length($_) > length($&)) {
>          push @candidate, $_;
>          $badness += (length($_) - length($&)) ** 1.5;
>      }
>  }
>  if ($badness > $threshold) {
>      warn about @candidate_lines;
>  }

I'd be OK with something like this while making the
current line length check a --strict only option.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/