linux-kernel - Re: kconfig: tristate choice with depender choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Feb 2012 00:26:25 -0500
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	Michal Marek <mmarek@...e.cz>, Sam Ravnborg <sam@...nborg.org>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: kconfig: tristate choice with depender choice

Hi,

On Thu, Feb 9, 2012 at 12:08 AM, Arnaud Lacombe <lacombar@...il.com> wrote:
> Hi,
>
> On Mon, Feb 6, 2012 at 7:16 PM, Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
>> If a tristate choice has another choice dependers, kconfig produce
>> wrong value.
>>
>> Example:
>>
>> choice
>>        prompt "choice list AB"
>> config A
>>        tristate "a"
>> config B
>>        tristate "b"
>> endchoice
>> choice
>>        prompt "choice list CD"
>>        depends on A
>> config C
>>        bool "c"
>> config D
>>        bool "d"
>> endchoice
>>
>> kconfig outputs CONFIG_A=m from defconfig with CONFIG_A=y.
>>
>> This happens if the choice list CD depends on A.
>> Also, if defconfig contains CONFIG_A=y and "# CONFIG_B is not set",
>> output is correct.
>>
> confirmed.
>
actually, not that much. Your reduced testcase is missing a MODULES
symbol to have modules enabled and have them show up in the final
`.config'. If you add:

config MODULES
  boolean
  default y

then you end up with CONFIG_A=m in the `.config'.

Now, I may have missed something.

Do you have a situation where a MODULES symbol is present, enabled,
but CONFIG_A=y still appear from CONFIG_A=m in the defconfig ?

Thanks,
 - Arnaud

>> I found commit a64b44ea ("kconfig: fix tristate choice with minimal
>> config"), but this problem still exists on v3.3-rc1.  More fix is
>> needed for choice with dependers?
>>
> it would seem so.
>
>  - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/