linux-kernel - Re: [PATCH 2/2] x86, reschedule: check to see if system is shutting down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120210225331.GO5650@redhat.com>
Date:	Fri, 10 Feb 2012 17:53:31 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	"x86@...nel.org" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"seiji.aguchi@....com" <seiji.aguchi@....com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"mjg@...hat.com" <mjg@...hat.com>,
	"levinsasha928@...il.com" <levinsasha928@...il.com>
Subject: Re: [PATCH 2/2] x86, reschedule: check to see if system is shutting
 down

On Fri, Feb 10, 2012 at 10:42:24PM +0000, Luck, Tony wrote:
> -		WARN_ON(1);
> +		if (atomic_read(&stopping_cpu) == -1)
> +			/* system is not shutting down.. yell */
> +			WARN_ON(1);
> 
> Should that be written as:
> 
> 		/* system is not shutting down.. yell */
> 		WARN_ON(atomic_read(&stopping_cpu) == -1);
> 
> the
> 		if (something)
> 			WARN_ON(1);
> 
> looks weird.

Indeed.  In my haste, I wrote some pretty sloppy code.

Thanks for catching that.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/