linux-kernel - RE: [PATCH 2/2] x86, reschedule: check to see if system is shutting down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F03AA72@ORSMSX104.amr.corp.intel.com>
Date:	Fri, 10 Feb 2012 22:42:24 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Don Zickus <dzickus@...hat.com>, "x86@...nel.org" <x86@...nel.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"seiji.aguchi@....com" <seiji.aguchi@....com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"mjg@...hat.com" <mjg@...hat.com>,
	"levinsasha928@...il.com" <levinsasha928@...il.com>
Subject: RE: [PATCH 2/2] x86, reschedule: check to see if system is shutting
 down

-		WARN_ON(1);
+		if (atomic_read(&stopping_cpu) == -1)
+			/* system is not shutting down.. yell */
+			WARN_ON(1);

Should that be written as:

		/* system is not shutting down.. yell */
		WARN_ON(atomic_read(&stopping_cpu) == -1);

the
		if (something)
			WARN_ON(1);

looks weird.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/