linux-kernel - Re: [PATCH V4 2/2] regmap: add regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F37A925.90507@metafoo.de>
Date:	Sun, 12 Feb 2012 12:57:25 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	broonie@...nsource.wolfsonmicro.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write

On 02/12/2012 09:49 AM, Laxman Dewangan wrote:
> [...]
> +	} else {
> +		for (i = 0; i < val_count; i++) {
> +			memcpy(&ival, val + (i * val_bytes), val_bytes);

This will have endianess issues. You'll need something like regcache_get_val.

> +			ret = _regmap_write(map, reg + i, ival);
> +			if (ret) {
> +				dev_err(map->dev,
> +				    "Error in register %u write, ret %d\n",
> +						reg + i, ret);
> +				break;
> +			}
> +		}
> +	}
> [...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/