linux-kernel - Re: [PATCH V4 2/2] regmap: add regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120212131101.GA3395@opensource.wolfsonmicro.com>
Date:	Sun, 12 Feb 2012 13:11:05 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write

On Sun, Feb 12, 2012 at 12:57:25PM +0100, Lars-Peter Clausen wrote:
> On 02/12/2012 09:49 AM, Laxman Dewangan wrote:
> > [...]
> > +	} else {
> > +		for (i = 0; i < val_count; i++) {
> > +			memcpy(&ival, val + (i * val_bytes), val_bytes);

> This will have endianess issues. You'll need something like regcache_get_val.

> > +			ret = _regmap_write(map, reg + i, ival);

Or just don't provide this fallback at all - it's not something the
underlying device supports anyway and none of the other block or bulk
operations work on these devices either.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)