linux-kernel - Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120215112009.GD2238@amd.com>
Date:	Wed, 15 Feb 2012 12:20:09 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	<linux-kernel@...r.kernel.org>, Michal Marek <mmarek@...e.cz>,
	maximilian attems <max@...o.at>,
	<debian-kernel@...ts.debian.org>, <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'

On Tue, Feb 14, 2012 at 02:49:13AM +0000, Ben Hutchings wrote:
> On Mon, 2012-02-13 at 15:48 +0100, Joerg Roedel wrote:
> > The Link to the kernel header files in the debian packages
> > point to the original build directory. This is a bad choice
> > if the packages were installed on a different machine. Fix
> > this in by manually re-creating the link in the builddeb
> > script.
> > 
> > Cc: Michal Marek <mmarek@...e.cz>
> > Cc: maximilian attems <max@...o.at>
> > Cc: Ben Hutchings <ben@...adent.org.uk>
> > Cc: debian-kernel@...ts.debian.org
> > Cc: linux-kbuild@...r.kernel.org
> > Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> 
> This looks good for !UML.
> 
> I wonder about the UML case though.  Did you test it?  In 3.3-rc3,
> 'make headers_install' is broken.  But if I suppress the header check,
> the resulting packages have links in the right places.

I havn't tested UML, I am not really familiar with using it. You are
probably right that for UML only the linux-image package is needed. I
can remove the UML check from this patch and post another one which
changes the script to only build linux-image for UML, how does that
sound?


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/