linux-kernel - Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1329313649.3048.72.camel@deadeye>
Date:	Wed, 15 Feb 2012 13:47:29 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	maximilian attems <max@...o.at>,
	debian-kernel@...ts.debian.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: Fix link to headers in 'make deb-pkg'

On Wed, 2012-02-15 at 12:20 +0100, Joerg Roedel wrote:
> On Tue, Feb 14, 2012 at 02:49:13AM +0000, Ben Hutchings wrote:
> > On Mon, 2012-02-13 at 15:48 +0100, Joerg Roedel wrote:
> > > The Link to the kernel header files in the debian packages
> > > point to the original build directory. This is a bad choice
> > > if the packages were installed on a different machine. Fix
> > > this in by manually re-creating the link in the builddeb
> > > script.
> > > 
> > > Cc: Michal Marek <mmarek@...e.cz>
> > > Cc: maximilian attems <max@...o.at>
> > > Cc: Ben Hutchings <ben@...adent.org.uk>
> > > Cc: debian-kernel@...ts.debian.org
> > > Cc: linux-kbuild@...r.kernel.org
> > > Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> > 
> > This looks good for !UML.
> > 
> > I wonder about the UML case though.  Did you test it?  In 3.3-rc3,
> > 'make headers_install' is broken.  But if I suppress the header check,
> > the resulting packages have links in the right places.
> 
> I havn't tested UML, I am not really familiar with using it. You are
> probably right that for UML only the linux-image package is needed. I
> can remove the UML check from this patch and post another one which
> changes the script to only build linux-image for UML, how does that
> sound?

Sounds good to me.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)