linux-kernel - Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be drained regardless of q->elevator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120215155740.GD27312@redhat.com>
Date:	Wed, 15 Feb 2012 10:57:40 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be
 drained regardless of q->elevator

On Mon, Feb 13, 2012 at 05:14:27PM -0800, Tejun Heo wrote:

[..]
>  		/*
>  		 * This function might be called on a queue which failed
> -		 * driver init after queue creation.  Some drivers
> -		 * (e.g. fd) get unhappy in such cases.  Kick queue iff
> -		 * dispatch queue has something on it.
> +		 * driver init after queue creation or is not yet fully
> +		 * active yet.  Some drivers (e.g. fd and loop) get unhappy
> +		 * in such cases.  Kick queue iff dispatch queue has
> +		 * something on it and @q has request_fn set.
>  		 */
> -		if (!list_empty(&q->queue_head))
> +		if (!list_empty(&q->queue_head) && q->request_fn)
>  			__blk_run_queue(q);

Is it not a BUG() condition. We have a queue which has some requests
in it and we don't have q->request_fn?

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/