linux-kernel - Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be drained regardless of q->elevator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F3BD5FC.30101@kernel.dk>
Date:	Wed, 15 Feb 2012 16:57:48 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Tejun Heo <tj@...nel.org>
CC:	linux-kernel@...r.kernel.org, Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be
 drained regardless of q->elevator

On 2012-02-14 02:14, Tejun Heo wrote:
> Currently, blk_cleanup_queue() doesn't call elv_drain_elevator() if
> q->elevator doesn't exist; however, bio based drivers don't have
> elevator initialized but can still use blk-throttle.  This patch moves
> q->elevator test inside blk_drain_queue() such that only
> elv_drain_elevator() is skipped if !q->elevator.
> 
> -v2: loop can have registered queue which has NULL request_fn.  Make
>      sure we don't call into __blk_run_queue() in such cases.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Vivek Goyal <vgoyal@...hat.com>
> Acked-by: Vivek Goyal <vgoyal@...hat.com>
> ---
> Added check against NULL q->request_fn for loop driver.  Thanks.

Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/