linux-kernel - Re: [PATCH] mtd: omap2: Release memory region in .remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Feb 2012 20:52:19 +0530
From:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
To:	Bernhard Walle <walle@...science.de>
Cc:	dwmw2@...radead.org, Artem.Bityutskiy@...ux.intel.com,
	vimal.newwork@...il.com, tony@...mide.com, s-ghorai@...com,
	linux-mtd@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: omap2: Release memory region in .remove function

On Fri, Feb 17, 2012 at 8:19 PM, Bernhard Walle <walle@...science.de> wrote:
> When the driver is compiled as module, it's not possible to unload and
> reload the driver again:
>
>    omap2-nand: probe of omap2-nand.0 failed with error -16
>
Looks right to me
Reviewed-by: Shubhrajyoti D <shubhrajyoti@...com>

> This patch fixes the problem because it releases the memory region, so
> that it can be requested again.
>
> Signed-off-by: Bernhard Walle <walle@...science.de>
> ---
>  drivers/mtd/nand/omap2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index b3a883e..7dfcf68 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1132,6 +1132,7 @@ static int omap_nand_remove(struct platform_device *pdev)
>        /* Release NAND device, its internal structures and partitions */
>        nand_release(&info->mtd);
>        iounmap(info->nand.IO_ADDR_R);
> +       release_mem_region(info->phys_base, NAND_IO_SIZE);
>        kfree(&info->mtd);
>        return 0;
>  }
> --
> 1.7.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/