linux-kernel - Re: [PATCH 1/2] rmap: Staticize page_referenced_file and page_referenced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFPAmTRrW4rAiC6UPGCFWChyuAjtbn7pkXRm3L2_SYdrRQCBZQ@mail.gmail.com>
Date:	Fri, 17 Feb 2012 10:19:49 -0500
From:	Kautuk Consul <consul.kautuk@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rmap: Staticize page_referenced_file and page_referenced_anon

On Fri, Feb 17, 2012 at 10:15 AM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> On Fri, 2012-02-17 at 09:27 -0500, Kautuk Consul wrote:
>> Staticize the page_referenced_anon and page_referenced_file
>> functions.
>> These functions are called only from page_referenced.
>
> Subject and changelog say: staticize, which I read to mean: make static.
> Yet what the patch does is make them inline ?!?

Yes, sorry my mistake. :)

>
> Also, if they're static and there's only a single callsite, gcc will
> already inline them, does this patch really make a difference?

I just sent this patch for what I thought was "correctness", but I guess
we can let this be if you are absolutely sure that all GCC cross compilers
for all platforms will guarantee inlining.



>
>> -static int page_referenced_anon(struct page *page,
>> +static inline int page_referenced_anon(struct page *page,
>
>


Please reply back if you feel I should resend this patch with modified
description.
Else, I'll just forget about this one. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/