linux-kernel - Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Feb 2012 21:34:21 -0200
From:	Jorgyano vieira <jorgyano@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, nsankar@...adcom.com,
	jarod@...sonet.com
Subject: Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro
 with pr_err

On Sat, Feb 18, 2012 at 9:14 PM, Joe Perches <joe@...ches.com> wrote:
> On Sat, 2012-02-18 at 21:08 -0200, Jorgyano vieira wrote:
>> > o pr_fmt needs to be #defined before any #include that might
>> >  directly or indirectly #include kernel.h/printk.h
>> >  use 'strings <path>/built-in.o | grep "^<.>"' to verify.
>> yes, I take care of this:--- a/drivers/staging/crystalhd/crystalhd_misc.h
>> +++ b/drivers/staging/crystalhd/crystalhd_misc.h
>> @@ -28,6 +28,8 @@
>>  #ifndef _CRYSTALHD_MISC_H_
>>  #define _CRYSTALHD_MISC_H_
>>
>> +#define pr_fmt(fmt)    KBUILD_MODNAME ": " fmt
>> +
>
> Maybe.
>
> $ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include" drivers/staging/crystalhd/
> drivers/staging/crystalhd/crystalhd_cmds.h:#include "crystalhd_misc.h"
> drivers/staging/crystalhd/crystalhd_lnx.c:#include <linux/mutex.h>
> drivers/staging/crystalhd/crystalhd_cmds.c:#include "crystalhd_cmds.h"
> drivers/staging/crystalhd/bc_dts_types.h:#include <stdint.h>
> drivers/staging/crystalhd/bc_dts_glob_lnx.h:#include <stdio.h>
> drivers/staging/crystalhd/crystalhd_misc.c:#include <linux/slab.h>
> drivers/staging/crystalhd/crystalhd_misc.h:#include <linux/module.h>
> drivers/staging/crystalhd/crystalhd_lnx.h:#include <linux/module.h>
> drivers/staging/crystalhd/crystalhd_hw.h:#include "crystalhd_misc.h"
> drivers/staging/crystalhd/crystalhd_hw.c:#include <linux/pci.h>
>
> so lnx, cmds, misc, and hw.c are/were suspect.
>

this is the output after the patch:

$ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include"
drivers/staging/crystalhd/
drivers/staging/crystalhd/crystalhd_misc.c:#include "crystalhd_misc.h"
drivers/staging/crystalhd/crystalhd_cmds.c:#include "crystalhd_cmds.h"
drivers/staging/crystalhd/crystalhd_lnx.c:#include "crystalhd_lnx.h"
drivers/staging/crystalhd/crystalhd_hw.h:#include "crystalhd_misc.h"
drivers/staging/crystalhd/bc_dts_glob_lnx.h:#include <stdio.h>
drivers/staging/crystalhd/crystalhd_cmds.h:#include "crystalhd_misc.h"
drivers/staging/crystalhd/crystalhd_misc.h:#include <linux/module.h>
drivers/staging/crystalhd/bc_dts_types.h:#include <stdint.h>
drivers/staging/crystalhd/crystalhd_hw.c:#include "crystalhd_hw.h"
drivers/staging/crystalhd/crystalhd_lnx.h:#include "crystalhd_cmds.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/