linux-kernel - Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329608726.1753.42.camel@joe2Laptop>
Date:	Sat, 18 Feb 2012 15:45:26 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jorgyano vieira <jorgyano@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, nsankar@...adcom.com,
	jarod@...sonet.com
Subject: Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro
 with pr_err

On Sat, 2012-02-18 at 21:34 -0200, Jorgyano vieira wrote:
> this is the output after the patch:
> $ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include"
[]
> drivers/staging/crystalhd/crystalhd_lnx.c:#include "crystalhd_lnx.h"

So this is still 2 layers indirected.

It might make more sense to have a
#include "crystalhd.h"
have pr_fmt be the first #define in that and have
crystalhd.h be the first #include in everything.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/