linux-kernel - Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120224194929.GA24613@kroah.com>
Date:	Fri, 24 Feb 2012 11:49:29 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jorgyano Vieira <jorgyano@...il.com>
Cc:	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	nsankar@...adcom.com, jarod@...sonet.com
Subject: Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro
 with pr_err

On Sat, Feb 18, 2012 at 08:10:20PM -0200, Jorgyano Vieira wrote:
> Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> Also added pr_fmt to identify the driver error messages.
> 
> Signed-ff-by: Jorgyano Vieira <jorgyano@...il.com>
> ---
>  drivers/staging/crystalhd/crystalhd_cmds.c |   68 ++++++++--------
>  drivers/staging/crystalhd/crystalhd_hw.c   |  119 ++++++++++++++--------------
>  drivers/staging/crystalhd/crystalhd_lnx.c  |   96 +++++++++++-----------
>  drivers/staging/crystalhd/crystalhd_lnx.h  |    4 +-
>  drivers/staging/crystalhd/crystalhd_misc.c |   70 ++++++++--------
>  drivers/staging/crystalhd/crystalhd_misc.h |   10 +--
>  6 files changed, 181 insertions(+), 186 deletions(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 3735ed3..46fac01 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -75,12 +75,12 @@ static enum BC_STATUS bc_cproc_notify_mode(struct crystalhd_cmd *ctx,
>  	int rc = 0, i = 0;
>  
>  	if (!ctx || !idata) {
> -		BCMLOG_ERR("Invalid Arg!!\n");
> +		pr_err("%s: Invalid Arg!!\n", __func__);

This is nice, but, as this is a driver, I really prefer the use of
dev_err() instead, which allows us to properly identify the device and
driver that spit out the error message.  Care to redo this patch in that
style instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/