linux-kernel - Re: [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD core v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120220154151.GA3258@opensource.wolfsonmicro.com>
Date:	Mon, 20 Feb 2012 07:41:55 -0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	linux-kernel@...r.kernel.org, Dajun <dajun.chen@...semi.com>
Subject: Re: [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD  core v2

On Mon, Feb 20, 2012 at 12:07:27PM +0000, Arnd Bergmann wrote:

> Also, I would recommend using request_irq instead of request_threaded_irq
> here because the function only has a single "complete()" call in it,
> just like a threaded IRQ handler has. There is no point going through
> another thread just to wake up the one that is blocked.

Actually in this case that won't work as the interrupt is generated by
the chip interrupt controller and as the chip is I2C/SPI controlled it
is itself threaded and can only generate threaded interrupts as genirq
can't get back into hard interrupt context.

As a result of this restriction when an interrupt handler doesn't care
what context it runs in it's better to use request_any_context_irq().
This will do a normal IRQ when it can but will bind successfully to a
threaded IRQ if that's what's provided.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)