lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Feb 2012 16:56:11 -0800 From: Linus Torvalds <torvalds@...ux-foundation.org> To: "H. Peter Anvin" <hpa@...or.com> Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de, akpm@...ux-foundation.org, hjl.tools@...il.com, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <greg@...ah.com> Subject: Re: [PATCH 08/30] compat: Use COMPAT_USE_64BIT_TIME in the lp driver On Sun, Feb 19, 2012 at 4:07 PM, H. Peter Anvin <hpa@...or.com> wrote: > From: "H. J. Lu" <hjl.tools@...il.com> > > Enable the lp driver to be used with a compat ABI with 64-bit time. Ugh. Is this really the only case? Because if it isn't, I suspect it would be much better off with a helper function. In fact, even if this *does* end up being the only place, a helper function to get/set a timeval from user space sounds like a good idea, and makes things much more readable than that ad-hoccery in the middle of code. IOW, I'd like to see something like get_user_timeval(void __user *tv, struct timeval *res) even if it would be only local to this file. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists