linux-kernel - Re: [PATCH] usb: enable pci MSI/MSIX in usb core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329699423.14084.9.camel@debian>
Date:	Mon, 20 Feb 2012 08:57:03 +0800
From:	"Alex,Shi" <alex.shi@...el.com>
To:	Andiry Xu <andiry.xu@....com>
Cc:	Clemens Ladisch <clemens@...isch.de>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	stern@...land.harvard.edu, Greg KH <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Oliver Neukum <oneukum@...e.de>, Takashi Iwai <tiwai@...e.de>,
	trenn@...e.de, linux-pci@...r.kernel.org,
	Michal Marek <MMarek@...e.com>
Subject: Re: [PATCH] usb: enable pci MSI/MSIX in usb core

> > Assume that an XHCI controller has two rings, and that each one gets its
> > own MSI-X interrupt.  How should the driver decide which of the rings
> > needs to be handled?
> > 
> > irqreturn_t xhci_msix_irq(struct usb_hcd *hcd)
> > {
> > 	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> > 
> > 	if (...)
> > 		handle(xhci->ring[0]);
> > 	else
> > 		handle(xhci->ring[1]);
> > }
> > 
> > I.e., what should go into the if()?
> > 
> > 
> 
> Currently xHCI driver only support one ERST event ring. If we need to
> support multiple event rings in the future, it's simple: in
> usb_hcd_request_msi_msix_irqs, change the last parameter of
> request_irq() to xhci->erst[i], and we can get the corresponding erst[i]
> in xhci_msi_irq() like this:
> 
> irqreturn_t xhci_msi_irq(int irq, void *dev_id)
> {
> 	struct xhci_erst *erst = dev_id;
> 	...
> 	/* Handle corresponding event ring pointed by erst */
> }
> 
> See Matthew Wilcox's patchset below for reference:
> 
> www.spinics.net/lists/linux-usb/msg47353.html

Oh. Thanks Andiry and Clemens! The problem really worth to have another
patchset for it. 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/