linux-kernel - [PATCH] checkpatch.pl: be silent when -q and --ignore is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1329921624-8559-1-git-send-email-dedekind1@gmail.com>
Date:	Wed, 22 Feb 2012 16:40:24 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Andy Whitcroft <apw@...onical.com>, Andrew Morton <akpm@...gle.com>
Cc:	Joe Perches <joe@...ches.com>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>
Subject: [PATCH] checkpatch.pl: be silent when -q and --ignore is given

From: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>

This patch fixes checkpatch.pl when both -q and --ignore are given and
prevents it from printing a

NOTE: Ignored message types: blah

messages.

E.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:

NOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED

It makes no sense to print this when -q is given.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
---
 scripts/checkpatch.pl |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..6fad217 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3394,13 +3394,12 @@ sub process {
 		}
 	}
 
-	if (keys %ignore_type) {
+	if ($quiet == 0 && keys %ignore_type) {
 	    print "NOTE: Ignored message types:";
 	    foreach my $ignore (sort keys %ignore_type) {
 		print " $ignore";
 	    }
-	    print "\n";
-	    print "\n" if ($quiet == 0);
+	    print "\n\n";
 	}
 
 	if ($clean == 1 && $quiet == 0) {
-- 
1.7.9

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/