linux-kernel - Re: [PATCH] ext4: MMP: Fix endianness bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120223214937.GC2636@granier.hd.free.fr>
Date:	Thu, 23 Feb 2012 22:49:37 +0100
From:	Johann Lombardi <johann@...mcloud.com>
To:	santoshprasadnayak@...il.com
Cc:	tytso@....edu, adilger@...ger.ca, andrew_perepechko@...atex.com,
	nikitas_angelinas@...atex.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: MMP: Fix endianness bug.

On Fri, Feb 24, 2012 at 12:39:05AM +0530, santoshprasadnayak@...il.com wrote:
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
>  	 * If check_interval in MMP block is larger, use that instead of
>  	 * update_interval from the superblock.
>  	 */
> -	if (mmp->mmp_check_interval > mmp_check_interval)
> -		mmp_check_interval = mmp->mmp_check_interval;
> +	if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> +		mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);

Looks good to me.
Reviewed-by: Johann Lombardi <johann@...mcloud.com>

Johann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/