linux-kernel - Re: [PATCH] ext4: MMP: Fix endianness bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Feb 2012 10:10:50 -0700
From:	Andreas Dilger <aedilger@...il.com>
To:	"santoshprasadnayak@...il.com" <santoshprasadnayak@...il.com>
Cc:	"tytso@....edu" <tytso@....edu>,
	"adilger@...ger.ca" <adilger@...ger.ca>,
	"andrew_perepechko@...atex.com" <andrew_perepechko@...atex.com>,
	"nikitas_angelinas@...atex.com" <nikitas_angelinas@...atex.com>,
	"johann@...mcloud.com" <johann@...mcloud.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Santosh Nayak <santoshprasadnayak@...il.com>
Subject: Re: [PATCH] ext4: MMP: Fix endianness bug.

On 2012-02-23, at 12:09, santoshprasadnayak@...il.com wrote:

> From: Santosh Nayak <santoshprasadnayak@...il.com>
> 
> Sparse complaint this endian bug in ext4: mmp.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com>

Looks good. 

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/mmp.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 7ea4ba4..ed6548d 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
>     * If check_interval in MMP block is larger, use that instead of
>     * update_interval from the superblock.
>     */
> -    if (mmp->mmp_check_interval > mmp_check_interval)
> -        mmp_check_interval = mmp->mmp_check_interval;
> +    if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> +        mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
> 
>    seq = le32_to_cpu(mmp->mmp_seq);
>    if (seq == EXT4_MMP_SEQ_CLEAN)
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/