linux-kernel - RE: [PATCH] IB: Fix potential mem leak in schedule_nes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1202262242290.6089@swampdragon.chaosbits.net>
Date:	Sun, 26 Feb 2012 22:43:06 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	"Latif, Faisal" <faisal.latif@...el.com>
cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"Hefty, Sean" <sean.hefty@...el.com>,
	Roland Dreier <roland@...nel.org>
Subject: RE: [PATCH] IB: Fix potential mem leak in schedule_nes_timer()

On Fri, 24 Feb 2012, Latif, Faisal wrote:

> I do not approve this patch. 
> 
> The type field is always set to either NES_TIMER_TYPE_SEND or 
> NES_TIMER_TYPE_CLOSE when schedule_nes_timer() is called. Even if we 
> wanted to make sure the value of type is one or the other, proper patch 
> can be just a if stmt to check the type before new_send allocation.
> 
Makes sense. I'll drop the patch for now.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/