[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120227172930.GB1650@thinkpad>
Date: Mon, 27 Feb 2012 18:29:30 +0100
From: Andrea Righi <andrea@...terlinux.com>
To: Dan Magenheimer <dan.magenheimer@...cle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Seth Jennings <sjenning@...ux.vnet.ibm.com>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
stable@...nel.org,
Alex Villacís Lasso
<a_villacis@...osanto.com>, Konrad Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH] zcache: avoid AB-BA deadlock condition
On Mon, Feb 27, 2012 at 09:23:24AM -0800, Dan Magenheimer wrote:
> > From: Andrea Righi [mailto:andrea@...terlinux.com]
> > Sent: Monday, February 20, 2012 5:12 AM
> > To: Greg Kroah-Hartman
> > Cc: Dan Magenheimer; Seth Jennings; devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org;
> > stable@...nel.org
> > Subject: [PATCH] zcache: avoid AB-BA deadlock condition
> >
> > Commit 9256a47 fixed a deadlock condition, being sure that the buddy
> > list spinlock is always taken before the page spinlock.
> >
> > However in zbud_free_and_delist() locking order is the opposite
> > (page lock -> list lock).
> >
> > Possible unsafe locking scenario (reported by lockdep):
> >
> > CPU0 CPU1
> > ---- ----
> > lock(&(&zbpg->lock)->rlock);
> > lock(zbud_budlists_spinlock);
> > lock(&(&zbpg->lock)->rlock);
> > lock(zbud_budlists_spinlock);
> >
> > Fix by grabbing the locks in opposite order in zbud_free_and_delist().
> >
> > Signed-off-by: Andrea Righi <andrea@...terlinux.com>
>
> Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>
>
> Thanks for catching this Andrea! (And thanks also to
> Alex Vallacis-Lasso for independently reporting and testing:
> http://permalink.gmane.org/gmane.linux.kernel/1257214 )
>
> Greg, this patch could be targeted for 3.3-rc6 and 3.2-stable.
> AFAIK, nobody has actually experienced a deadlock from this so
> if Linus has the screws down tight for -rc6, it could wait
> until the 3.4 window.
If it helps, without the fix I can easily trigger the lockdep splat
running a echo 3 > /proc/sys/vm/drop_caches.
-Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists