linux-kernel - RE: [PATCH] zcache: avoid AB-BA deadlock condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e60d5136-c2d2-45a4-97f4-5d8e58b12000@default>
Date:	Mon, 27 Feb 2012 09:23:24 -0800 (PST)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Andrea Righi <andrea@...terlinux.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	stable@...nel.org,
	Alex Villacís Lasso 
	<a_villacis@...osanto.com>, Konrad Wilk <konrad.wilk@...cle.com>,
	Alex Villacís Lasso 
	<a_villacis@...osanto.com>
Subject: RE: [PATCH] zcache: avoid AB-BA deadlock condition

> From: Andrea Righi [mailto:andrea@...terlinux.com]
> Sent: Monday, February 20, 2012 5:12 AM
> To: Greg Kroah-Hartman
> Cc: Dan Magenheimer; Seth Jennings; devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org;
> stable@...nel.org
> Subject: [PATCH] zcache: avoid AB-BA deadlock condition
> 
> Commit 9256a47 fixed a deadlock condition, being sure that the buddy
> list spinlock is always taken before the page spinlock.
> 
> However in zbud_free_and_delist() locking order is the opposite
> (page lock -> list lock).
> 
> Possible unsafe locking scenario (reported by lockdep):
> 
>         CPU0                    CPU1
>         ----                    ----
>    lock(&(&zbpg->lock)->rlock);
>                                 lock(zbud_budlists_spinlock);
>                                 lock(&(&zbpg->lock)->rlock);
>    lock(zbud_budlists_spinlock);
> 
> Fix by grabbing the locks in opposite order in zbud_free_and_delist().
> 
> Signed-off-by: Andrea Righi <andrea@...terlinux.com>

Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>

Thanks for catching this Andrea!  (And thanks also to
Alex Vallacis-Lasso for independently reporting and testing:
http://permalink.gmane.org/gmane.linux.kernel/1257214 )

Greg, this patch could be targeted for 3.3-rc6 and 3.2-stable.
AFAIK, nobody has actually experienced a deadlock from this so
if Linus has the screws down tight for -rc6, it could wait
until the 3.4 window.

> ---
>  drivers/staging/zcache/zcache-main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index ef7c52b..dce04be 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -299,10 +299,12 @@ static void zbud_free_and_delist(struct zbud_hdr *zh)
>  	struct zbud_page *zbpg =
>  		container_of(zh, struct zbud_page, buddy[budnum]);
> 
> +	spin_lock(&zbud_budlists_spinlock);
>  	spin_lock(&zbpg->lock);
>  	if (list_empty(&zbpg->bud_list)) {
>  		/* ignore zombie page... see zbud_evict_pages() */
>  		spin_unlock(&zbpg->lock);
> +		spin_unlock(&zbud_budlists_spinlock);
>  		return;
>  	}
>  	size = zbud_free(zh);
> @@ -310,7 +312,6 @@ static void zbud_free_and_delist(struct zbud_hdr *zh)
>  	zh_other = &zbpg->buddy[(budnum == 0) ? 1 : 0];
>  	if (zh_other->size == 0) { /* was unbuddied: unlist and free */
>  		chunks = zbud_size_to_chunks(size) ;
> -		spin_lock(&zbud_budlists_spinlock);
>  		BUG_ON(list_empty(&zbud_unbuddied[chunks].list));
>  		list_del_init(&zbpg->bud_list);
>  		zbud_unbuddied[chunks].count--;
> @@ -318,7 +319,6 @@ static void zbud_free_and_delist(struct zbud_hdr *zh)
>  		zbud_free_raw_page(zbpg);
>  	} else { /* was buddied: move remaining buddy to unbuddied list */
>  		chunks = zbud_size_to_chunks(zh_other->size) ;
> -		spin_lock(&zbud_budlists_spinlock);
>  		list_del_init(&zbpg->bud_list);
>  		zcache_zbud_buddied_count--;
>  		list_add_tail(&zbpg->bud_list, &zbud_unbuddied[chunks].list);
> --
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/