linux-kernel - Re: [PATCH v2] parisc: dont unconditionally override CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330399020.2822.106.camel@dabdike.int.hansenpartnership.com>
Date:	Tue, 28 Feb 2012 03:17:01 +0000
From:	James Bottomley <jbottomley@...allels.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"kyle@...artin.ca" <kyle@...artin.ca>,
	"deller@....de" <deller@....de>,
	"dave.anglin@...l.net" <dave.anglin@...l.net>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE
 for 64 bit.

On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> > 
> > -CROSS_COMPILE	:= hppa64-linux-gnu-
> > +
> > +# if no default set, try to find the corresponding 64 bit compiler
> > +ifeq ($(CROSS_COMPILE),)
> > +CROSS_COMPILE	:= $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
> > +endif
> 
> fails when using "hppa2.0-xxx".  perhaps:
> CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/')
> 
> don't even need the ifeq check then

How is that different from Carlos' suggestion?  The reason it doesn't
work is the same ... CROSS_COMPILE is defined to be empty.

James