linux-kernel - Re: [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120228133037.GG2817@mwanda>
Date:	Tue, 28 Feb 2012 16:30:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Dmitry Antipov <dmitry.antipov@...aro.org>
Cc:	Rusty Russell <rusty.russell@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linaro-dev@...ts.linaro.org, patches@...aro.org
Subject: Re: [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR

On Tue, Feb 28, 2012 at 03:59:25PM +0400, Dmitry Antipov wrote:
> On 02/28/2012 01:44 PM, Dan Carpenter wrote:
> >On Tue, Feb 28, 2012 at 01:33:59PM +0400, Dmitry Antipov wrote:
> >>  - Fix vmap() to return ZERO_SIZE_PTR if 0 pages are requested;
> >>  - fix __vmalloc_node_range() to return ZERO_SIZE_PTR if 0 bytes
> >>    are requested;
> >>  - fix __vunmap() to check passed pointer with ZERO_OR_NULL_PTR.
> >>
> >
> >Why?
> 
> 1) it was requested by the subsystem (co?)maintainer, see http://lkml.org/lkml/2012/1/27/475;
> 2) this looks to be a convenient way to trace/debug zero-size allocation errors (although
>    I don't advocate it as a best way).

Could you include that in the changelog when the final version is
ready?

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)