linux-kernel - Re: lockdep: Warning & NULL ptr deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Feb 2012 14:29:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Dave Jones <davej@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: lockdep: Warning & NULL ptr deref

On Tue, 2012-02-28 at 10:24 -0500, Sasha Levin wrote:
> 
> I'll send some patches to prevent the NULL deref itself which happens
> since a chunk of the code in lockdep.c assumed hlock_class() can't
> return NULL.
> 
There's tons of code actually assuming that..

> This won't fix the actual problem though, I'm not sure exactly how a
> held lock wouldn't have a class initialized to it. 

static inline struct lock_class *hlock_class(struct held_lock *hlock)                        
{               
        if (!hlock->class_idx) {                                                             
                /*
                 * Someone passed in garbage, we give up.                                    
                 */                                                                          
                DEBUG_LOCKS_WARN_ON(1);                                                      
                return NULL;
        }
        return lock_classes + hlock->class_idx - 1; 
}

Typically that translates to severe memory corruption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/