linux-kernel - Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F4CD781.2090802@antcom.de>
Date:	Tue, 28 Feb 2012 14:32:49 +0100
From:	Roland Stigge <stigge@...com.de>
To:	David Laight <David.Laight@...LAB.COM>
CC:	baruch@...s.co.il, alexander.h.duyck@...el.com,
	ian.campbell@...rix.com, netdev@...r.kernel.org,
	eilong@...adcom.com, Kevin Wells <kevin.wells@....com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	jeffrey.t.kirsher@...el.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

Hi,

On 02/28/2012 02:11 PM, David Laight wrote:
>> Thanks for the note! I actually found out that in many cases, the
>> bootloader already initialized the hardware with the target 
>> MAC address so we can use this one.
>>
>> For the case that it _isn't_ initialized already, is it the right
> thing
>> to use a hard coded default MAC address to be replaced by the final
> one
>> in userspace? (I found such examples in some current micrel/ and amd/
> drivers.)
> 
> Using a fixed address is a very bad idea ...

Yes, that's why we previously had a cmdline param for it (but removed it
upon request from the netdev maintainer).

So if the hardware defaults to 00:00:00:00:00:00, what is the
"consistent policy we want to enforce in all drivers"?

A link or hint would be sufficient.

Thanks in advance,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/