linux-kernel - Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201202281341.01690.arnd@arndb.de>
Date:	Tue, 28 Feb 2012 13:41:01 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Roland Stigge <stigge@...com.de>
Cc:	David Laight <David.Laight@...lab.com>, baruch@...s.co.il,
	alexander.h.duyck@...el.com, ian.campbell@...rix.com,
	netdev@...r.kernel.org, eilong@...adcom.com,
	Kevin Wells <kevin.wells@....com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	jeffrey.t.kirsher@...el.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

On Tuesday 28 February 2012, Roland Stigge wrote:
> Yes, that's why we previously had a cmdline param for it (but removed it
> upon request from the netdev maintainer).
> 
> So if the hardware defaults to 00:00:00:00:00:00, what is the
> "consistent policy we want to enforce in all drivers"?
> 
> A link or hint would be sufficient.

I think the most common strategy for platform drivers these days is

1. use what the hardware provides
2. call of_get_mac_address(dev->of_node, ...)
3. use random_ether_addr

in that order. of_get_mac_address just returns NULL when there
is no device tree or no local-mac-address property, so you can
put it into the driver right away.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/