linux-kernel - Re: + procfs-mark-thread-stack-correctly-in-proc-pid-maps.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAHN_R1hmJt4zCxGAL7z2-9URmWUFwwV9pcqkdvQZodpunEJjQ@mail.gmail.com>
Date:	Tue, 28 Feb 2012 22:48:18 +0530
From:	Siddhesh Poyarekar <siddhesh.poyarekar@...il.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jamie Lokier <jamie@...reable.org>,
	Mike Frysinger <vapier@...too.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Matt Mackall <mpm@...enic.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: + procfs-mark-thread-stack-correctly-in-proc-pid-maps.patch added
 to -mm tree

On Tue, Feb 28, 2012 at 10:34 PM, Oleg Nesterov <oleg@...hat.com> wrote:
>> +int vm_is_stack(struct task_struct *task,
>> +                           struct vm_area_struct *vma, int in_group)
>> +{
>> +     if (vm_is_stack_for_task(task, vma))
>> +             return 1;
>> +
>> +     if (in_group) {
>> +             struct task_struct *t = task;
>> +             while_each_thread(task, t) {
>> +                     if (vm_is_stack_for_task(t, vma))
>> +                             return 1;
>> +             }
>> +     }
>> +
>> +     return 0;
>> +}
>
> This is obviously wrong, while_each_thread() is not safe without
> tasklist or siglock or rcu.

I have fixed this in my git stash. I'll submit once I get to work on
Mike Frysinger's idea of marking stacks with their tids and see if it
breaks anything.

-- 
Siddhesh Poyarekar
http://siddhesh.in
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/