linux-kernel - Re: [PATCH 2/2] powerpc/44x: Add more changes for APM821XX EMAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120229.132513.1607879808995168004.davem@davemloft.net>
Date:	Wed, 29 Feb 2012 13:25:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jwboyer@...il.com
Cc:	dhdang@....com, benh@...nel.crashing.org, paulus@...ba.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] powerpc/44x: Add more changes for APM821XX EMAC
 driver

From: Josh Boyer <jwboyer@...il.com>
Date: Wed, 29 Feb 2012 08:43:46 -0500

> On Fri, Feb 17, 2012 at 3:07 AM, Duc Dang <dhdang@....com> wrote:
>> This patch includes:
>>
>>  Configure EMAC PHY clock source (clock from PHY or internal clock).
>>
>>  Do not advertise PHY half duplex capability as APM821XX EMAC does not
>> support half duplex mode.
>>
>>  Add changes to support configuring jumbo frame for APM821XX EMAC.
>>
>> Signed-off-by: Duc Dang <dhdang@....com>
> 
> This should have been sent to netdev.  CC'ing them now.
> 
> Ben and David, I can take this change through the 4xx tree if it looks OK to
> both of you.  The pre-requisite DTS patch will go through my tree, so it might
> make sense to keep them together.

Well the patch has coding style problems, for one:

>> +			dev->features |= (EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE
>> +					| EMAC_FTR_APM821XX_NO_HALF_DUPLEX
>> +					| EMAC_FTR_460EX_PHY_CLK_FIX);

Should be:

>> +			dev->features |= (EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE |
>> +					  EMAC_FTR_APM821XX_NO_HALF_DUPLEX |
>> +					  EMAC_FTR_460EX_PHY_CLK_FIX);

And this:

>> +		dev->phy_feat_exc = (SUPPORTED_1000baseT_Half
>> +					| SUPPORTED_100baseT_Half
>> +					| SUPPORTED_10baseT_Half);

Should be:

>> +		dev->phy_feat_exc = (SUPPORTED_1000baseT_Half |
>> +				     SUPPORTED_100baseT_Half |
>> +				     SUPPORTED_10baseT_Half);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/