linux-kernel - Re: [PATCH] DS2781 Maxim Stand-Alone Fuel Gauge battery and w1 slave drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120229185259.GC32077@ioremap.net>
Date:	Wed, 29 Feb 2012 21:52:59 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Renata Sayakhova <rsayakhova@...il.com>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: [PATCH] DS2781 Maxim Stand-Alone Fuel Gauge battery and w1
 slave drivers

Hi Renata

On Wed, Feb 29, 2012 at 02:58:53PM +0100, Renata Sayakhova (rsayakhova@...il.com) wrote:
> 
> Signed-off-by: Renata Sayakhova <rsayakhova@...il.com>

Patch looks good except this weird function

> +static inline int ds2781_battery_io(struct ds2781_device_info *dev_info,
> +	char *buf, int addr, size_t count, int io)
> +{
> +	if (dev_info->mutex_holder == current)
> +		return w1_ds2781_io_nolock(dev_info->w1_dev, buf, addr,
> +				count, io);
> +	else
> +		return w1_ds2781_io(dev_info->w1_dev, buf, addr, count, io);
> +}

Who in the stack can run away holding mutex?

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/